Safe refresh #32
Closed
Safe refresh #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| field=models.CharField(default='UTC', max_length=128), | ||
| preserve_default=False, | ||
| ), | ||
| ] |
There was a problem hiding this comment.
@brad What do you think about renaming this file to 0006_add_expires_timezone_fields.py?
There was a problem hiding this comment.
@percyperez Oh yeah, of course!
| @@ -13,6 +13,9 @@ class UserFitbit(models.Model): | |||
| access_token = models.TextField() | |||
| auth_secret = models.TextField() | |||
| refresh_token = models.TextField() | |||
| # We will store the timestamp float number as it comes from Fitbit here | |||
| expires_at = models.FloatField() | |||
| timezone = models.CharField(max_length=128) | |||
There was a problem hiding this comment.
@brad I see that the migration file for the timezone field has default='UTC'. Did you remove default='UTC' here after the migration file was created? If not, how default='UTC' was added to the migration file?
There was a problem hiding this comment.
@percyperez When I ran makemigrations it asked for a default and I specifie UTC
|
|
||
|
|
||
| @shared_task | ||
| def update_user_timezone(fitbit_user): |
|
Superseded by #33 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@orcasgit/orcas-developers This has turned out to be a bit of a refactor, but I think refreshing tokens works better now. The changes:
expires_atandtimezonefieldstransaction.atomic()decorator to theget_fitbit_datamethod.UserFitbitobject rather than dealing with the session