add optional position mint params #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fuzzyyeti
commented
Nov 10, 2023
yugure-orca
reviewed
Nov 10, 2023
There was a problem hiding this comment.
return value of getEphemeralSigners
Could you check the return value of getEphemeralSigners method ?
As far as I read the documentation, the return value is Pubkey.
If it is a PDA, the private key should not exist theoretically.
Checking if a method returns a different value each time
It is explained that this function is for use with createAccount, so we should be able to create an account.
However, we don't want the same value returned over and over again. Could you please ask with the Squads team to see if it changes each time or if it can be changed.
If we explain to them what we want to do, they will probably have some good advice.
yugure-orca
approved these changes
Nov 13, 2023
sdk/src/whirlpool-client.ts
Outdated
| @@ -1,6 +1,6 @@ | |||
| import { Address } from "@coral-xyz/anchor"; | |||
| import { Percentage, TransactionBuilder } from "@orca-so/common-sdk"; | |||
| import { PublicKey } from "@solana/web3.js"; | |||
| import {Keypair, PublicKey } from "@solana/web3.js"; | |||
There was a problem hiding this comment.
nit: Keypair is no longer used.
sdk/src/impl/whirlpool-impl.ts
Outdated
| @@ -276,14 +281,15 @@ export class WhirlpoolImpl implements Whirlpool { | |||
| `upper tick ${tickUpper} is not an initializable tick for tick-spacing ${whirlpool.tickSpacing}` | |||
| ); | |||
|
|
|||
| const positionMintKeypair = Keypair.generate(); | |||
| const positionMintKeypair = Keypair.generate(); | |||
There was a problem hiding this comment.
super nit: This change is not needed (" " added)
Note
see also |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an optional parameter to specify the positionMint instead of generating it internally. This allows the ability to assign an ephemeral keypair that can be saved for later execution in the case of a multi-sig wallet.