Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Qualifier is unnecessary and can be removed #164

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Qualifier is unnecessary and can be removed #164

wants to merge 2 commits into from

Conversation

bomshteyn
Copy link

There is no need to use slash in \DB::table() PHPStorm gives warning: Qualifier is unnecessary and can be removed

This pull request fixes this.

yazeed
yazeed approved these changes Nov 27, 2020
View reviewed changes
Copy link

@yazeed yazeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@tihomiro
Copy link
Member

If a qualifier is removed, it still needs to be used in the class head in order to resolve. Plz update the PR with use statements, and it seems that a couple of instances of \DB:: occurrences have been missed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yazeed yazeed yazeed approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bomshteyn @tihomiro @yazeed