Skip to content

Commit

Permalink
Merge pull request #81 from opzkit/checkovs
Browse files Browse the repository at this point in the history
chore: disable unwanted checks
  • Loading branch information
peter-svensson authored Jul 18, 2024
2 parents 6a90f16 + ff3d4da commit cc4834b
Show file tree
Hide file tree
Showing 5 changed files with 17 additions and 2 deletions.
1 change: 1 addition & 0 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
name: Build
permissions: read-all

on: [ push, workflow_dispatch ]

Expand Down
1 change: 1 addition & 0 deletions .github/workflows/checkov.yaml
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
name: checkov
permissions: read-all

# Controls when the workflow will run
on:
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/commitlint.yaml
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
name: Lint Commit Messages
permissions: read-all

on: [pull_request]

Expand Down
4 changes: 2 additions & 2 deletions k8s.tf
Original file line number Diff line number Diff line change
Expand Up @@ -375,8 +375,8 @@ data "aws_security_group" "nodes" {
}

module "cluster_autoscaler" {
source = "opzkit/k8s-addons-cluster-autoscaler/aws"
version = "1.28.2"
source = "git::https://github.com/opzkit/terraform-aws-k8s-addons-cluster-autoscaler.git?ref=f2237759ca43fbfac35c998b7c26e0b7887b160c"
# version = "1.28.2"
replicas = local.min_number_of_nodes > 1 ? 2 : 1
cluster_name = var.name
}
12 changes: 12 additions & 0 deletions s3.tf
Original file line number Diff line number Diff line change
@@ -1,16 +1,28 @@
resource "aws_s3_bucket" "issuer" {
#checkov:skip=CKV_AWS_18
#checkov:skip=CKV_AWS_21
#checkov:skip=CKV_AWS_144
#checkov:skip=CKV_AWS_145
#checkov:skip=CKV2_AWS_6
#checkov:skip=CKV2_AWS_61
#checkov:skip=CKV2_AWS_62
bucket = "${replace(var.name, ".", "-")}-irsa-issuer"
force_destroy = true
}

resource "aws_s3_bucket_ownership_controls" "issuer" {
#checkov:skip=CKV2_AWS_65
bucket = aws_s3_bucket.issuer.id
rule {
object_ownership = "BucketOwnerPreferred"
}
}

resource "aws_s3_bucket_public_access_block" "issuer" {
#checkov:skip=CKV_AWS_53
#checkov:skip=CKV_AWS_54
#checkov:skip=CKV_AWS_55
#checkov:skip=CKV_AWS_56
bucket = aws_s3_bucket.issuer.id
block_public_acls = false
block_public_policy = false
Expand Down

0 comments on commit cc4834b

Please sign in to comment.