Skip to content

Commit

Permalink
Button to dismiss Danger Dialog should read Cancel
Browse files Browse the repository at this point in the history
This corrects a mistake in the implementation. The original Acceptance
Criteria specified "Cancel" as button text:

https://community.openproject.org/projects/openproject/work_packages/58680/activity#acceptance-criteria
  • Loading branch information
myabc committed Jan 14, 2025
1 parent 2deecbd commit 285b6f2
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
<% end %>
</scrollable-region>
<%= render(Primer::Alpha::Dialog::Footer.new(show_divider: false)) do %>
<%= render(Primer::Beta::Button.new(data: { "close-dialog-id": dialog_id })) { I18n.t("button_close") } %>
<%= render(Primer::Beta::Button.new(data: { "close-dialog-id": dialog_id })) { I18n.t("button_cancel") } %>
<%= render(Primer::Beta::Button.new(type: (@form_wrapper.shows_form? ? :submit : :button), scheme: :danger, data: { "submit-dialog-id": dialog_id })) { I18n.t("button_delete_permanently") } %>
<% end %>
<% end %>
Expand Down

0 comments on commit 285b6f2

Please sign in to comment.