Skip to content

Commit

Permalink
Merge pull request #235 from opf/changeset-release/main
Browse files Browse the repository at this point in the history
Release Tracking
  • Loading branch information
HDinger authored Feb 4, 2025
2 parents 4f5e002 + deda528 commit 1d2a349
Show file tree
Hide file tree
Showing 8 changed files with 23 additions and 23 deletions.
11 changes: 0 additions & 11 deletions .changeset/fast-yaks-smell.md

This file was deleted.

5 changes: 0 additions & 5 deletions .changeset/gorgeous-ravens-exercise.md

This file was deleted.

16 changes: 16 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,21 @@
# CHANGELOG

## 0.53.0

### Minor Changes

- [#234](https://github.com/opf/primer_view_components/pull/234) [`cdb335c`](https://github.com/opf/primer_view_components/commit/cdb335ce1d5caad3cde8d4ee945461516f229577) Thanks [@myabc](https://github.com/myabc)! - [#60588] Implementation of Danger Dialog, a generalised dialog for "potentially dangerous" actions such as item deletion.
There are two variants:

1. **the default (or "warning") variant**, requiring the user to click the dialog confirmation button to continue.
2. **the second confirmation variant**, which requires the user to check a check box AND click confirm to continue with the operation.

This is a BREAKING change, which renames `DangerConfirmationDialog` to `DangerDialog`. Callers will need to update the class name and consider which behaviour they wish to present to the end user. The confirmation variant behaviour is enabled by defining a `confirmation_check_box` slot.

### Patch Changes

- [#234](https://github.com/opf/primer_view_components/pull/234) [`de20e6d`](https://github.com/opf/primer_view_components/commit/de20e6d74e1a5f4a97799d4664eed51e17e729cf) Thanks [@myabc](https://github.com/myabc)! - Fix DangerDialog body scroll behaviour: the dialog's body scroll behaviour should be in parity with that of the underlying `Primer::Alpha::Dialog` component.

## 0.52.4

### Patch Changes
Expand Down
2 changes: 1 addition & 1 deletion Gemfile.lock
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
PATH
remote: .
specs:
openproject-primer_view_components (0.52.4)
openproject-primer_view_components (0.53.0)
actionview (>= 5.0.0)
activesupport (>= 5.0.0)
openproject-octicons (>= 19.20.0)
Expand Down
2 changes: 1 addition & 1 deletion demo/Gemfile.lock
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
PATH
remote: ..
specs:
openproject-primer_view_components (0.52.4)
openproject-primer_view_components (0.53.0)
actionview (>= 5.0.0)
activesupport (>= 5.0.0)
openproject-octicons (>= 19.20.0)
Expand Down
4 changes: 2 additions & 2 deletions lib/primer/view_components/version.rb
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@ module Primer
module ViewComponents
module VERSION
MAJOR = 0
MINOR = 52
PATCH = 4
MINOR = 53
PATCH = 0

STRING = [MAJOR, MINOR, PATCH].join(".")
end
Expand Down
4 changes: 2 additions & 2 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@openproject/primer-view-components",
"version": "0.52.4",
"version": "0.53.0",
"description": "ViewComponents of the Primer Design System for OpenProject",
"main": "app/assets/javascripts/primer_view_components.js",
"module": "app/components/primer/primer.js",
Expand Down

0 comments on commit 1d2a349

Please sign in to comment.