Skip to content

Commit

Permalink
Merge pull request #225 from opf/fix/danger_confirmation_dialog-cance…
Browse files Browse the repository at this point in the history
…l-button

Button to dismiss Danger Dialog should read Cancel
  • Loading branch information
HDinger authored Jan 15, 2025
2 parents 2deecbd + 6ae694b commit 198763d
Show file tree
Hide file tree
Showing 9 changed files with 6 additions and 1 deletion.
5 changes: 5 additions & 0 deletions .changeset/slow-pans-applaud.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@openproject/primer-view-components': patch
---

Changes button text to dismiss Danger Dialog from "Close" to "Cancel"
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
<% end %>
</scrollable-region>
<%= render(Primer::Alpha::Dialog::Footer.new(show_divider: false)) do %>
<%= render(Primer::Beta::Button.new(data: { "close-dialog-id": dialog_id })) { I18n.t("button_close") } %>
<%= render(Primer::Beta::Button.new(data: { "close-dialog-id": dialog_id })) { I18n.t("button_cancel") } %>
<%= render(Primer::Beta::Button.new(type: (@form_wrapper.shows_form? ? :submit : :button), scheme: :danger, data: { "submit-dialog-id": dialog_id })) { I18n.t("button_delete_permanently") } %>
<% end %>
<% end %>
Expand Down

0 comments on commit 198763d

Please sign in to comment.