Remove no-op emoji reactions tooltip icon definition #17713
Draft
+1
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Button tooltip does not support icons, futher the linked code would fail with a NoMethodError as `EmojiReactions.emoji` is not defined (note the plural definition) which should be singular `EmojiReaction.emoji` This was just forgotten, never gets executed.
akabiru
force-pushed
the
fix/incorrect-tool-tip
branch
from
c2ed610 to
7353d83
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Button tooltip does not support icons, further the linked code would fail with a NoMethodError as
EmojiReactions.emojiis not defined (note the plural definition) which should be singularEmojiReaction.emojiThis was just forgotten, never gets executed. See unit specs for the component: https://github.com/opf/openproject/blob/dev/spec/components/work_packages/activities_tab/journals/item_component/reactions_spec.rb
Primer ref:
https://qa.openproject-edge.com/lookbook/inspect/primer/beta/button/with_tooltip
https://github.com/opf/primer_view_components/blob/main/app/components/primer/beta/button.rb#L94