Replace invalid octal escape sequences in RegEx

TypeScript 5.5 introduces syntax checking for regexen. See: https://www.typescriptlang.org/docs/handbook/release-notes/typescript-5-5.html#regular-expression-syntax-checking
opf · Jan 24, 2025 · 53736bf · 53736bf
1 parent 8896c1d
commit 53736bf
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/modules/github_integration/frontend/module/git-actions/git-actions.service.ts b/modules/github_integration/frontend/module/git-actions/git-actions.service.ts
@@ -38,8 +38,8 @@ export class GitActionsService {
     return str
       .replace(/&/g, 'and ') // & becomes and
       .replace(/ +/g, '-') // Spaces become dashes
-      .replace(/[\000-\039]/g, '') // ASCII control characters are out
-      .replace(/\177/g, '') // DEL is out
+      .replace(/[\x00-\x1F]/g, '') // ASCII control characters are out
+      .replace(/\x7F/g, '') // DEL is out
       .replace(/[#\\\/\?\*\~\^\:\{\}@\.\[\]'"]/g, '') // Some other characters with special rules are out
       .replace(/^[-]+/g, '') // Dashes at the start are removed
       .replace(/[-]+$/g, '') // Dashes at the end are removed

diff --git a/modules/gitlab_integration/frontend/module/git-actions/git-actions.service.ts b/modules/gitlab_integration/frontend/module/git-actions/git-actions.service.ts
@@ -41,8 +41,8 @@ export class GitActionsService {
     return str
       .replace(/&/g, 'and ') // & becomes and
       .replace(/ +/g, '-') // Spaces become dashes
-      .replace(/[\000-\039]/g, '') // ASCII control characters are out
-      .replace(/\177/g, '') // DEL is out
+      .replace(/[\x00-\x1F]/g, '') // ASCII control characters are out
+      .replace(/\x7F/g, '') // DEL is out
       .replace(/[#\\\/\?\*\~\^\:\{\}@\.\[\]'"]/g, '') // Some other characters with special rules are out
       .replace(/^[-]+/g, '') // Dashes at the start are removed
       .replace(/[-]+$/g, '') // Dashes at the end are removed