Docker repo use vars #494
Merged
Docker repo use vars #494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
qrkourier
commented
Dec 14, 2023
| @@ -0,0 +1,2 @@ | |||
| [flake8] | |||
| max-line-length = 120 | |||
There was a problem hiding this comment.
Let's use flake8 to express our consensus to adopt PEP 8.
qrkourier
commented
Dec 14, 2023
| @@ -35,6 +35,7 @@ jobs: | |||
| - name: Build distro | |||
| env: | |||
| ZROK_VERSION: ${{ github.event.release.tag_name }} | |||
| ZROK_PY_NAME: ${{ vars.ZROK_PY_NAME || null }} | |||
There was a problem hiding this comment.
Get the PyPi module name from a var if exists, else set null. There's a counterpart change in setup.py to handle both cases.
qrkourier
commented
Dec 14, 2023
| @@ -72,11 +72,12 @@ jobs: | |||
|
|
|||
| - name: Set Up Container Image Tags for zrok CLI Container | |||
| env: | |||
| RELEASE_REPO: openziti/zrok | |||
| ZROK_VERSION: ${{ steps.semver.outputs.zrok_semver }} | |||
| ZROK_CONTAINER_IMAGE_REPO: ${{ vars.ZROK_CONTAINER_IMAGE_REPO || 'openziti/zrok' }} | |||
There was a problem hiding this comment.
This corrects a flaw where a release in a fork will try unsuccessfully, or worse, successfully, to publish to the upstream's Docker Hub registry repo.
qrkourier
commented
Dec 14, 2023
| from setuptools import find_packages, setup # noqa: H301 | ||
|
|
||
| # optionally upload to TestPyPi with alternative name in testing repo | ||
| NAME = os.getenv('ZROK_PY_NAME', "zrok_sdk") |
There was a problem hiding this comment.
Use the new var if defined, else use the same name zrok_sdk (normalizes to zrok-sdk in PyPi)
camotts
approved these changes
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and enable testing in forks with alternate PyPi module name from var