Add request to reserved return JSON #441
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
qrkourier
force-pushed
the
linux-service-package
branch
2 times, most recently
from
9f0ddd0 to
2edc18d
Compare
qrkourier
force-pushed
the
add-request-to-reserved-return
branch
from
6a4e0c3 to
fc9bd6c
Compare
qrkourier
force-pushed
the
linux-service-package
branch
from
2edc18d to
221e288
Compare
qrkourier
force-pushed
the
add-request-to-reserved-return
branch
2 times, most recently
from
db45099 to
3104546
Compare
qrkourier
force-pushed
the
linux-service-package
branch
2 times, most recently
from
11590dc to
c3d5e7e
Compare
…r we need to provision a new share
qrkourier
force-pushed
the
add-request-to-reserved-return
branch
from
3104546 to
bb9c9f1
Compare
|
I don't understand why it's helpful to return something that was passed in to a function? The caller already has that information... Or, maybe there's a better way to do what you're trying to accomplish? |
|
Let's revisit this later as a potential refinement of the Linux server operator experience, e.g. the possibility of zrok keeping track of shares and handling changes to backend mode or authentication for a reserved share. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable the system service to determine if we need to provision a new share because the requested reservation has changed.