refinements to original add-verify-ext-jwt-oidc #2710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+5
to
+7
| * Moved `ziti ops verify-network` to `ziti ops verify network` | ||
| * Moved `ziti ops verify traffic` to `ziti ops verify traffic` | ||
| * Added `ziti ops verify ext-jwt-signer oidc` to help users with configuring OIDC external auth |
There was a problem hiding this comment.
This breaks backward compatibility. We usually care about that for other commands. These though? I don't feel strongly as they are debugging tools.
There was a problem hiding this comment.
We can move it.
We can leave stub commands that direct users to the new commands.
We can leave the old commands present, but hidden, with a deprecation warning.
I'm fine with any of those.
andrewpmartinez
approved these changes
Jan 30, 2025
|
based on the still relative newness of verify-network/verify-traffic, i'm fine with just moving them and not providing any hints back. people use these commands highly infrequently (if at all). thx |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2711
slight refactorings to make the verify-ext-jwt command actually be
ext-jwt-signer. This pattern is emerging too, I plan to change the verify commands all to subcommands