Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tunneler intercept mode on linux only #2709

Merged
merged 2 commits into from
Jan 29, 2025
Merged

tunneler intercept mode on linux only #2709

merged 2 commits into from
Jan 29, 2025

Conversation

dovholuknf
Copy link
Member

An effort to stop seeing the tunneling error on anything not linux since it won't work on windows/macos and this error isn't relevant on either OS

[   8.513]   ERROR ziti/tunnel/dns.NewDnsServer: system resolver test failed: failed to resolve ziti-tunnel.resolver.test: lookup ziti-tunnel.resolver.test: no such host

ziti-tunnel runs an internal DNS server which must be first in the host's
resolver configuration. On systems that use NetManager/dhclient, this can
be achieved by adding the following to /etc/dhcp/dhclient.conf:

    prepend domain-name-servers 127.0.0.1:53;

@dovholuknf dovholuknf requested review from a team as code owners January 29, 2025 12:03
@dovholuknf dovholuknf changed the title don't try to start tunneler in intercept mode unless on linux tunneler intercept mode on linux only Jan 29, 2025
Copy link
Member

@scareything scareything left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO it would be more direct to have dns_linux.go for the linux implementation and dns.go for the stub. Otherwise lgtm.

@dovholuknf
Copy link
Member Author

IMO it would be more direct to have dns_linux.go for the linux implementation and dns.go for the stub. Otherwise lgtm.

I am to please! I'll rename 'em

@dovholuknf dovholuknf merged commit 1dbe459 into main Jan 29, 2025
36 checks passed
@dovholuknf dovholuknf deleted the tunnel-linux-only branch January 29, 2025 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants