Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set appropriate filemodes on unwrapped identity files #2706

Merged
merged 3 commits into from
Jan 29, 2025

Conversation

qrkourier
Copy link
Member

@qrkourier qrkourier commented Jan 28, 2025

On !windows systems, it's currently necessary to correct the filemode on unwrapped files. This respects the filemode mask on POSIX systems with appropriate defaults and always sets the default mode on Windows:

  • owner: read+write on key, cert, ca
  • group, others: read-only on cert, ca

@qrkourier qrkourier requested review from a team as code owners January 28, 2025 21:59
@qrkourier qrkourier linked an issue Jan 28, 2025 that may be closed by this pull request
Copy link
Member

@andrewpmartinez andrewpmartinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just ensure new files have our NF header.

@qrkourier qrkourier merged commit f836191 into main Jan 29, 2025
36 checks passed
@qrkourier qrkourier deleted the fix-filemode-ops-unwrap branch January 29, 2025 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ziti ops unwrap - invalid filemode
2 participants