Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add verify ext jwt OIDC #2702

Merged
merged 9 commits into from
Jan 29, 2025
Merged

Add verify ext jwt OIDC #2702

merged 9 commits into from
Jan 29, 2025

Conversation

dovholuknf
Copy link
Member

closes #2701

Adds ziti ops verify-ext-auth oidc to the ziti CLI to hopefully assist users when configuring/testing their IdP of choice

@dovholuknf dovholuknf requested review from a team as code owners January 27, 2025 22:48

// NewClientApiClient returns a new management client for use with the controller using the set of login material provided
func (o *LoginOptions) NewClientApiClient() (*rest_client_api_client.ZitiEdgeClient, error) {
client, err := int_rest_client.NewClientApiClient()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another create API client function.

The Go Ziti SKD has an implementation that supports credentials and HA fallback. I don't know if it is a drop-in for here, but I see this very commonly in the CLI codebase; different API bootstraps.

Copy link
Member

@andrewpmartinez andrewpmartinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its fine, but at some point we have to stop re-inventing the API/HTTP client/credential wheel over and over and start using the Go SDK facilities.

@dovholuknf dovholuknf force-pushed the add-verify-ext-jwt-oidc branch 2 times, most recently from 139cdc6 to 21f1ff5 Compare January 28, 2025 22:03
@dovholuknf dovholuknf merged commit ec06ce2 into main Jan 29, 2025
36 checks passed
@dovholuknf dovholuknf deleted the add-verify-ext-jwt-oidc branch January 29, 2025 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

help users debug ext-jwt-signers
2 participants