-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add verify ext jwt OIDC #2702
Add verify ext jwt OIDC #2702
Conversation
…ng a template for better command legibility
ziti/cmd/edge/login.go
Outdated
|
||
// NewClientApiClient returns a new management client for use with the controller using the set of login material provided | ||
func (o *LoginOptions) NewClientApiClient() (*rest_client_api_client.ZitiEdgeClient, error) { | ||
client, err := int_rest_client.NewClientApiClient() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another create API client function.
The Go Ziti SKD has an implementation that supports credentials and HA fallback. I don't know if it is a drop-in for here, but I see this very commonly in the CLI codebase; different API bootstraps.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Its fine, but at some point we have to stop re-inventing the API/HTTP client/credential wheel over and over and start using the Go SDK facilities.
139cdc6
to
21f1ff5
Compare
closes #2701
Adds
ziti ops verify-ext-auth oidc
to the ziti CLI to hopefully assist users when configuring/testing their IdP of choice