fixes #2681 adds targetToken support for ext jwt signers #2686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
andrewpmartinez
commented
Jan 23, 2025
andrewpmartinez
commented
- adds targetToken of values ACCESS, ID for management API CRUD
- adds targetToken to client API reads
- adds --target-token to external jwt signers CLI
- updates/adds tests
- adds targetToken of values ACCESS, ID for management API CRUD - adds targetToken to client API reads - adds --target-token to external jwt signers CLI - updates/adds tests
dovholuknf
reviewed
Jan 23, 2025
|
|
||
| DefaultClaimsProperty = "sub" | ||
|
|
||
| TargetTokenAccess = "ACCESS" |
dovholuknf
reviewed
Jan 23, 2025
| Kid: S(uuid.New().String()), | ||
| Issuer: S(uuid.NewString()), | ||
| Audience: S(uuid.NewString()), | ||
| TargetToken: ToPtr(rest_model.TargetTokenID), |
There was a problem hiding this comment.
should there be a test when it's left empty or when it's an invalid value? i didn't see such a test but it's kinda hard to scan for a missing value
dovholuknf
reviewed
Jan 23, 2025
| Kid: S(uuid.NewString()), | ||
| Issuer: S(uuid.NewString()), | ||
| Audience: S(uuid.NewString()), | ||
| TargetToken: nil, |
There was a problem hiding this comment.
oh i think i found the nil test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.