Implement idempotency for sdk terminators. Fixes #1446

openziti · Nov 29, 2023 · a2b5373 · a2b5373
1 parent 8c75d0b
commit a2b5373
Show file tree

Hide file tree

Showing 45 changed files with 2,937 additions and 1,037 deletions.
diff --git a/common/pb/ctrl_pb/ctrl.pb.go b/common/pb/ctrl_pb/ctrl.pb.go
diff --git a/common/pb/ctrl_pb/ctrl.proto b/common/pb/ctrl_pb/ctrl.proto
@@ -36,6 +36,8 @@ enum ContentType {
   RemoveTerminatorsRequestType = 1038;
   QuiesceRouterRequestType = 1039;
   DequiesceRouterRequestType = 1040;
+  ValidateTerminatorsV2RequestType = 1041;
+  ValidateTerminatorsV2ResponseType = 1042;
 
   PeerStateChangeRequestType = 1050;
 
@@ -108,6 +110,26 @@ message ValidateTerminatorsRequest {
   repeated Terminator terminators = 1;
 }
 
+message ValidateTerminatorsV2Request {
+  repeated Terminator terminators = 1;
+}
+
+enum TerminatorInvalidReason {
+  UnknownBinding = 0;
+  UnknownTerminator = 1;
+  BadState = 2;
+}
+
+message RouterTerminatorState {
+  bool valid = 1;
+  TerminatorInvalidReason reason = 2;
+  string detail = 3; // inspect info if valid
+}
+
+message ValidateTerminatorsV2Response {
+  map<string, RouterTerminatorState> states = 1;
+}
+
 message UpdateTerminatorRequest {
   string terminatorId = 1;
   bool updatePrecedence = 2;

diff --git a/common/pb/ctrl_pb/impl.go b/common/pb/ctrl_pb/impl.go
@@ -50,6 +50,14 @@ func (request *ValidateTerminatorsRequest) GetContentType() int32 {
 	return int32(ContentType_ValidateTerminatorsRequestType)
 }
 
+func (request *ValidateTerminatorsV2Request) GetContentType() int32 {
+	return int32(ContentType_ValidateTerminatorsV2RequestType)
+}
+
+func (request *ValidateTerminatorsV2Response) GetContentType() int32 {
+	return int32(ContentType_ValidateTerminatorsV2ResponseType)
+}
+
 func (request *Dial) GetContentType() int32 {
 	return int32(ContentType_DialType)
 }

diff --git a/common/pb/mgmt_pb/impl.go b/common/pb/mgmt_pb/impl.go
@@ -11,3 +11,15 @@ func (request *InspectResponse) GetContentType() int32 {
 func (request *RaftMemberListResponse) GetContentType() int32 {
 	return int32(ContentType_RaftListMembersResponseType)
 }
+
+func (request *ValidateTerminatorsRequest) GetContentType() int32 {
+	return int32(ContentType_ValidateTerminatorsRequestType)
+}
+
+func (request *ValidateTerminatorsResponse) GetContentType() int32 {
+	return int32(ContentType_ValidateTerminatorResponseType)
+}
+
+func (request *TerminatorDetail) GetContentType() int32 {
+	return int32(ContentType_ValidateTerminatorResultType)
+}