Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No hook but cache #1164

Merged
merged 1 commit into from
Jan 30, 2025
Merged

No hook but cache #1164

merged 1 commit into from
Jan 30, 2025

Conversation

aparcar
Copy link
Member

@aparcar aparcar commented Jan 24, 2025

Stop relying on web hooks but instead dynamically update whatever is required.

asu/routers/api.py Outdated Show resolved Hide resolved
@efahl
Copy link
Contributor

efahl commented Jan 25, 2025

Except for that part you pointed out, looks ready to go.

Are you going to roll it out to a test instance first? Let me know the url if you do.

@aparcar aparcar force-pushed the no-hook branch 4 times, most recently from 6fa5062 to de1717f Compare January 25, 2025 23:25
@efahl
Copy link
Contributor

efahl commented Jan 26, 2025

We've got maybe 20 tests against the staging server, across a variety of targets and versions. https://forum.openwrt.org/t/owut-openwrt-upgrade-tool/200035/432

Looks good!

@aparcar aparcar force-pushed the no-hook branch 12 times, most recently from 47220ea to 383ccb8 Compare January 28, 2025 00:15
@efahl
Copy link
Contributor

efahl commented Jan 29, 2025

@aparcar I assume you've seen the 500s from various calls by now. Here are the headers from one of them, in case it has anything useful:

$ curl -v https://sysupgrade.staging.openwrt.org/json/v1/releases/24.10-SNAPSHOT/targets/x86/64/index.json
> GET /json/v1/releases/24.10-SNAPSHOT/targets/x86/64/index.json HTTP/2
> Host: sysupgrade.staging.openwrt.org
> User-Agent: curl/8.10.1
> Accept: */*
>
< HTTP/2 500
< access-control-allow-credentials: true
< access-control-allow-headers: *
< access-control-allow-methods: POST, GET, OPTIONS
< access-control-allow-origin: *
< access-control-expose-headers: Authorization
< alt-svc: h3=":443"; ma=2592000
< content-type: text/plain; charset=utf-8
< date: Wed, 29 Jan 2025 02:15:39 GMT
< server: Caddy
< server: uvicorn
< vary: Origin
< content-length: 21
<
Internal Server Error

@aparcar aparcar force-pushed the no-hook branch 2 times, most recently from 96fb2c0 to 080be49 Compare January 29, 2025 22:47
No longer require web hooks but instead cache things and upload them on
demand. Stuff from /json/v1/ stays the same, even though no longer
stored as files.

This ideally solves a forever standing issue were things get outdated
and are just dreadful to debug.

Signed-off-by: Paul Spooren <[email protected]>
@aparcar aparcar merged commit aa7a790 into openwrt:main Jan 30, 2025
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants