Split out common functionality and implement device specific module #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…file Having common functionality separated from the specific ones makes it easier to implement for a target device which is not the emulator. Both can still share the same common functionality. Open-webOS-DCO-1.0-Signed-off-by: Simon Busch <[email protected]>
The implementation is based on the common linux power supply interface and is detected changes to the current status with processing uevents due to the use of libudev. Open-webOS-DCO-1.0-Signed-off-by: Simon Busch <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main aspect of this pull request is the device specific implementation of the battery module. It's using libudev right now to detect battery status changes and the common linux power supply interface. This makes it usable for every linux device using the require kernel version 3.3 by the openwebos project.
Please tell me if you have any questions about the implementation.
regards,
Simon