feat: export connection alert modal #1408
Conversation
Signed-off-by: ZouidiSamih <[email protected]>
Signed-off-by: ZouidiSamih <[email protected]>
Signed-off-by: ZouidiSamih <[email protected]>
bryce-mcmath
changed the title
bryce-mcmath
changed the title
| @@ -715,7 +715,7 @@ const ProofRequest: React.FC<ProofRequestProps> = ({ navigation, proofId }) => { | |||
| </InfoTextBox> | |||
| )} | |||
| {!loading && proofConnectionLabel && goalCode === 'aries.vc.verify' ? ( | |||
There was a problem hiding this comment.
While we're looking at this, it would be a little cleaner to modify the check to:
{(!loading && proofConnectionLabel && goalCode === 'aries.vc.verify') ?? (
connectionAlert({ connectionID: proofConnectionLabel })
)}There was a problem hiding this comment.
Thank you for the feedback! I've implemented the suggested changes
| @@ -75,6 +74,7 @@ const CredentialOffer: React.FC<CredentialOfferProps> = ({ navigation, credentia | |||
| const { start } = useTour() | |||
| const screenIsFocused = useIsFocused() | |||
| const goalCode = useOutOfBandByConnectionId(credential?.connectionId ?? '')?.outOfBandInvitation?.goalCode | |||
| const [connectionAlert] = useServices([TOKENS.COMPONENT_CONNECTION_ALERT]) | |||
There was a problem hiding this comment.
Could we opt to use capitalized components and JSX for injectables like this? Following something like PINCreateHeader for example, ie.
const [ConnectionAlert] = useServices([TOKENS.COMPONENT_CONNECTION_ALERT])
...
{credentialConnectionLabel && goalCode === 'aries.vc.issue' ? (
<ConnectionAlert connectionID={credentialConnectionLabel} />
) : null}
It makes it easier to identify what is being rendered at a glance
There was a problem hiding this comment.
Thank you for the feedback! I've implemented the suggested changes
| @@ -279,7 +279,7 @@ const CredentialOffer: React.FC<CredentialOfferProps> = ({ navigation, credentia | |||
| > | |||
| {loading ? <RecordLoading /> : null} | |||
| {credentialConnectionLabel && goalCode === 'aries.vc.issue' ? ( | |||
| <ConnectionAlert connectionID={credentialConnectionLabel} /> | |||
| connectionAlert({ connectionID: credentialConnectionLabel }) | |||
There was a problem hiding this comment.
This is the second part of the suggested change referenced in comment above
…ConnectionAlert Signed-off-by: ZouidiSamih <[email protected]>
Signed-off-by: ZouidiSamih <[email protected]>
Signed-off-by: ZouidiSamih <[email protected]>
|
|
@ZouidiSamih nicely done! |
Summary of Changes
Exported the connection alert model to improve its reusability across components/modules.
Screenshots, videos, or gifs
N/A
Breaking change guide
N/A
Related Issues
N/A
Pull Request Checklist
Tick all boxes below to demonstrate that you have completed the respective task. If the item does not apply to your this PR check it anyway to make it apparent that there's nothing to do.
Signed-off-byline (we use the DCO GitHub app to enforce this)