-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update react native hotfix version #1388
base: main
Are you sure you want to change the base?
Conversation
@jleach it looks like you're having the same problem we had here in QC with the iOS build about hermes-engine. I've tried running the command |
@fc-santos Kind of odd, I did a similar PR to BC Wallet and it worked fine. Working to spot the difference. |
@jleach the problem comes from a mismatch between the Podfile.lock and the Pods/Local\ Podspecs/hermes-engines.podspec.json. There is a reference in this json file to react native 0.72.5 where it should be 0.72.17. |
@fc-santos I aligned the Podfile to be more like what BC is using and cleared all the GitHub caches for the workflows. Let's see how this goes. |
Signed-off-by: Jason C. Leach <[email protected]>
Signed-off-by: Jason C. Leach <[email protected]>
Signed-off-by: Jason C. Leach <[email protected]>
Signed-off-by: Jason C. Leach <[email protected]>
Signed-off-by: Jason C. Leach <[email protected]>
d895a84
to
d7973ed
Compare
Quality Gate passedIssues Measures |
Summary of Changes
To fix an issue with the Boost package I've updating React Native from 0.72.5 to 0.72.17. This also requires and update to the minimum SDK supported by Android. This is being updated from 22 to 23.
To do this in your own project, you will need to:
bundle exec pod install
orpod install
or update to update the Podfile.lock./gradlew app:dependencies --write-locks
to update your gradle.lockfile.Screenshots, videos, or gifs
n/a
Breaking change guide
Minimum supported Android SDK to 23.
Related Issues
n/a
Pull Request Checklist
Tick all boxes below to demonstrate that you have completed the respective task. If the item does not apply to your this PR check it anyway to make it apparent that there's nothing to do.
Signed-off-by
line (we use the DCO GitHub app to enforce this)If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!
Pro Tip 🤓