Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update react native hotfix version #1388

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

jleach
Copy link
Contributor

@jleach jleach commented Jan 10, 2025

Summary of Changes

To fix an issue with the Boost package I've updating React Native from 0.72.5 to 0.72.17. This also requires and update to the minimum SDK supported by Android. This is being updated from 22 to 23.

To do this in your own project, you will need to:

  1. Yarn install to update the RN package verison
  2. bundle exec pod install or pod install or update to update the Podfile.lock
  3. ./gradlew app:dependencies --write-locks to update your gradle.lockfile.
  4. Edit build.gradle to bump your minimum SDK.

Screenshots, videos, or gifs

n/a

Breaking change guide

Minimum supported Android SDK to 23.

Related Issues

n/a

Pull Request Checklist

Tick all boxes below to demonstrate that you have completed the respective task. If the item does not apply to your this PR check it anyway to make it apparent that there's nothing to do.

  • All commits contain a DCO Signed-off-by line (we use the DCO GitHub app to enforce this)
  • If applicable, screenshots, gifs, or video are included for UI changes
  • If applicable, breaking changes are described above along with how to address them
  • Updated documentation as needed for changed code and new or modified features
  • Added sufficient tests so that overall code coverage is not reduced

If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!

Pro Tip 🤓

  • Read our contribution guide at least once; it will save you a few review cycles!
  • Your PR will likely not be reviewed until all the above boxes are checked and all automated checks have passed

@fc-santos
Copy link
Contributor

@jleach it looks like you're having the same problem we had here in QC with the iOS build about hermes-engine. I've tried running the command pod update hermes-engine --no-repo-update in the pipeline but it didn't solve the problem. It looks like it's a problem of how in the pipeline the iOS dependencies are cached. When I removed the steps related to caching, I did not get the error from the build-ios step, but of course that shouldn't be the solution to the problem. If you find the solution, please let us know :)

@jleach
Copy link
Contributor Author

jleach commented Jan 10, 2025

@fc-santos Kind of odd, I did a similar PR to BC Wallet and it worked fine. Working to spot the difference.

@fc-santos
Copy link
Contributor

@jleach the problem comes from a mismatch between the Podfile.lock and the Pods/Local\ Podspecs/hermes-engines.podspec.json. There is a reference in this json file to react native 0.72.5 where it should be 0.72.17.

@jleach
Copy link
Contributor Author

jleach commented Jan 10, 2025

@fc-santos I aligned the Podfile to be more like what BC is using and cleared all the GitHub caches for the workflows. Let's see how this goes.

Signed-off-by: Jason C. Leach <[email protected]>
Signed-off-by: Jason C. Leach <[email protected]>
Signed-off-by: Jason C. Leach <[email protected]>
Signed-off-by: Jason C. Leach <[email protected]>
@jleach jleach force-pushed the fix/update-rn-hotfix branch from d895a84 to d7973ed Compare January 11, 2025 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants