fix: added missing back buttons to settings pages #1387
Conversation
updated header for biometry, update pin, terms and push notifications screens in the settings stack Signed-off-by: al-rosenthal <[email protected]>
Signed-off-by: al-rosenthal <[email protected]>
Good call, there were two dispatch events in the |
Moved back navigation special case logic to onboarding flow and left back navigation apart of the default screen options Signed-off-by: al-rosenthal <[email protected]>
| @@ -51,7 +51,7 @@ export class AppContainer implements Container { | |||
| } | |||
|
|
|||
| public resolve<K extends keyof TokenMapping>(token: K): TokenMapping[K] { | |||
| return this._container.resolve(token) as TokenMapping[K] | |||
There was a problem hiding this comment.
Why this change? It seems unrelated
There was a problem hiding this comment.
I've got a sonar cube plugin and flagged the casting as unnecessary
| @@ -23,7 +23,7 @@ export class AppContainer implements Container { | |||
|
|
|||
| //This is an example of how to customize the screen layout and use custom header for wallets who wnat to hide default navigation header | |||
| //To hide navigation header for a specific page, use headerShown: false in the screen options like this | |||
| /* | |||
| /** | |||
There was a problem hiding this comment.
Why this change? Left over from when you were thinking of moving this commented example?
There was a problem hiding this comment.
I decided to leave the comment where it is as it doesn't make much sense in the default config either. My sonar cube plugin also flags this to be deleted but with /** it treats it as more than just a code block
| @@ -207,7 +207,7 @@ export class MainContainer implements Container { | |||
| } | |||
|
|
|||
| public resolve<K extends keyof TokenMapping>(token: K): TokenMapping[K] { | |||
| return this._container.resolve(token) as TokenMapping[K] | |||
There was a problem hiding this comment.
I've got a sonar cube plugin and flagged the casting as unnecessary
|
Summary of Changes
updated header for biometry, update pin, terms and push notifications screens in the settings stack
Screenshots, videos, or gifs
n/a
Breaking change guide
n/a
Related Issues
BC Wallet: 2338
Pull Request Checklist
Tick all boxes below to demonstrate that you have completed the respective task. If the item does not apply to your this PR check it anyway to make it apparent that there's nothing to do.
Signed-off-byline (we use the DCO GitHub app to enforce this)If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!
Pro Tip 🤓