Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: added missing back buttons to settings pages #1387

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

al-rosenthal
Copy link
Contributor

Summary of Changes

updated header for biometry, update pin, terms and push notifications screens in the settings stack

Screenshots, videos, or gifs

n/a

Breaking change guide

n/a

Related Issues

BC Wallet: 2338

Pull Request Checklist

Tick all boxes below to demonstrate that you have completed the respective task. If the item does not apply to your this PR check it anyway to make it apparent that there's nothing to do.

  • All commits contain a DCO Signed-off-by line (we use the DCO GitHub app to enforce this)
  • If applicable, screenshots, gifs, or video are included for UI changes
  • If applicable, breaking changes are described above along with how to address them
  • Updated documentation as needed for changed code and new or modified features
  • Added sufficient tests so that overall code coverage is not reduced

If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!

Pro Tip 🤓

  • Read our contribution guide at least once; it will save you a few review cycles!
  • Your PR will likely not be reviewed until all the above boxes are checked and all automated checks have passed

updated header for biometry, update pin, terms and push notifications screens in the settings stack

Signed-off-by: al-rosenthal <[email protected]>
@al-rosenthal al-rosenthal requested a review from a team as a code owner January 10, 2025 20:06
Copy link
Contributor

@bryce-mcmath bryce-mcmath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this event / event emitter used anywhere else in the code base? Is there going to be any dead code because of this change that could be removed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants