Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add accessibilityLabel to language radio button for state #1384

Conversation

fc-santos
Copy link
Contributor

Summary of Changes

This PR adds a translation to the state of the BouncyCheckbox used in the Language Screen. The accessibilityState prop checked is not translated by the VoiceOver. By adding the state to the accessibilityLabel of the BouncyCheckbox, the VoiceOver will read the text + the state (e.g: English checked radio button, French not checked radio button, Portuguese not checked radio button).

Screenshots, videos, or gifs

N/A

Breaking change guide

N/A

Related Issues

N/A

Pull Request Checklist

Tick all boxes below to demonstrate that you have completed the respective task. If the item does not apply to your this PR check it anyway to make it apparent that there's nothing to do.

  • All commits contain a DCO Signed-off-by line (we use the DCO GitHub app to enforce this)
  • If applicable, screenshots, gifs, or video are included for UI changes
  • If applicable, breaking changes are described above along with how to address them
  • Updated documentation as needed for changed code and new or modified features
  • Added sufficient tests so that overall code coverage is not reduced

If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!

Pro Tip 🤓

  • Read our contribution guide at least once; it will save you a few review cycles!
  • Your PR will likely not be reviewed until all the above boxes are checked and all automated checks have passed

@fc-santos fc-santos requested a review from a team as a code owner January 8, 2025 21:17
@jleach jleach enabled auto-merge (squash) January 9, 2025 21:34
Signed-off-by: fc-santos <[email protected]>
@jleach jleach merged commit 5b9b85e into openwallet-foundation:main Jan 10, 2025
2 checks passed
@fc-santos fc-santos deleted the chore/add-accessibility-label-to-language-checkbox branch January 11, 2025 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants