-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add accessibility props to components and screens #1370
chore: add accessibility props to components and screens #1370
Conversation
Signed-off-by: fc-santos <[email protected]>
@@ -283,7 +283,7 @@ const UseBiometry: React.FC = () => { | |||
{biometryAvailable ? ( | |||
<View> | |||
<Text style={TextTheme.normal}>{t('Biometry.EnabledText1')}</Text> | |||
<Text></Text> | |||
<Text accessible={false}></Text> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if these aren't rending text we should just remove them and add padding if we need the space
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The vast majority of these changes are great, but I agree with Alfred that we should remove the empty <Text>
tags
Signed-off-by: fc-santos <[email protected]>
Signed-off-by: fc-santos <[email protected]>
Quality Gate passedIssues Measures |
@bryce-mcmath Are you able to tell why my last two PR's that were merged into main failed on the Alpha Release step ? I checked the logs and it's weird. |
@fc-santos It is weird! I'm looking into it but so far I don't know what is causing it. All of the latest npm alpha versions are at 400 and the latest github tag is 400, but it's attempting to publish 402 instead of 401. That could have something to do with it but I'm pretty sure it's been able to skip a version in the past and still publish without issue. |
Summary of Changes
This PR adds accessibility props to components/screens that were missing it.
Screenshots, videos, or gifs
N/A
Breaking change guide
N/A
Related Issues
N/A
Pull Request Checklist
Tick all boxes below to demonstrate that you have completed the respective task. If the item does not apply to your this PR check it anyway to make it apparent that there's nothing to do.
Signed-off-by
line (we use the DCO GitHub app to enforce this)If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!
Pro Tip 🤓