Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add accessibility props to components and screens #1370

Conversation

fc-santos
Copy link
Contributor

Summary of Changes

This PR adds accessibility props to components/screens that were missing it.

Screenshots, videos, or gifs

N/A

Breaking change guide

N/A

Related Issues

N/A

Pull Request Checklist

Tick all boxes below to demonstrate that you have completed the respective task. If the item does not apply to your this PR check it anyway to make it apparent that there's nothing to do.

  • All commits contain a DCO Signed-off-by line (we use the DCO GitHub app to enforce this)
  • If applicable, screenshots, gifs, or video are included for UI changes
  • If applicable, breaking changes are described above along with how to address them
  • Updated documentation as needed for changed code and new or modified features
  • Added sufficient tests so that overall code coverage is not reduced

If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!

Pro Tip 🤓

  • Read our contribution guide at least once; it will save you a few review cycles!
  • Your PR will likely not be reviewed until all the above boxes are checked and all automated checks have passed

@jcdrouin21 jcdrouin21 requested review from jleach, MosCD3 and bryce-mcmath and removed request for jleach and MosCD3 December 20, 2024 16:25
@@ -283,7 +283,7 @@ const UseBiometry: React.FC = () => {
{biometryAvailable ? (
<View>
<Text style={TextTheme.normal}>{t('Biometry.EnabledText1')}</Text>
<Text></Text>
<Text accessible={false}></Text>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if these aren't rending text we should just remove them and add padding if we need the space

Copy link
Contributor

@bryce-mcmath bryce-mcmath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The vast majority of these changes are great, but I agree with Alfred that we should remove the empty <Text> tags

Copy link

sonarqubecloud bot commented Jan 2, 2025

@bryce-mcmath bryce-mcmath merged commit 5c0f8ec into openwallet-foundation:main Jan 3, 2025
8 checks passed
@fc-santos
Copy link
Contributor Author

fc-santos commented Jan 3, 2025

@bryce-mcmath Are you able to tell why my last two PR's that were merged into main failed on the Alpha Release step ? I checked the logs and it's weird.

@bryce-mcmath
Copy link
Contributor

@fc-santos It is weird! I'm looking into it but so far I don't know what is causing it. All of the latest npm alpha versions are at 400 and the latest github tag is 400, but it's attempting to publish 402 instead of 401. That could have something to do with it but I'm pretty sure it's been able to skip a version in the past and still publish without issue.

@fc-santos fc-santos deleted the chore/add-accessibility-props-to-components-and-screens branch January 11, 2025 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants