chore: improve biometrics permission prompting. #1301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tom11-nguyen
force-pushed
the
chore/prompt-biometrics-permission-onboarding
branch
from
09b373d to
650edc3
Compare
al-rosenthal
reviewed
Nov 5, 2024
| @@ -153,9 +238,9 @@ const UseBiometry: React.FC = () => { | |||
| <ToggleButton | |||
| testID={testIdWithKey("ToggleBiometrics")} | |||
| isEnabled={biometryEnabled} | |||
| isAvailable={biometryAvailable} | |||
| isAvailable={true} | |||
There was a problem hiding this comment.
is it ok that these are hard coded values? the diff shows biometryAvailable
There was a problem hiding this comment.
Yes, it was changed so that the biometric switch is now always enabled for interaction, it will shows a popup with messages when biometryAvailable == false; instead of being disabled from interacting entirely before this change.
al-rosenthal
approved these changes
Nov 5, 2024
bryce-mcmath
reviewed
Nov 5, 2024
Yes, I did test that screen, too |
bryce-mcmath
approved these changes
Nov 6, 2024
added 9 commits
November 6, 2024 15:30
…cs switch during onboarding, add new strings. Signed-off-by: Nguyen, Tom CITZ:EX <[email protected]>
…iometric is unavailable. Signed-off-by: Nguyen, Tom CITZ:EX <[email protected]>
Signed-off-by: Nguyen, Tom CITZ:EX <[email protected]>
Signed-off-by: Nguyen, Tom CITZ:EX <[email protected]>
Signed-off-by: Nguyen, Tom CITZ:EX <[email protected]>
Signed-off-by: Nguyen, Tom CITZ:EX <[email protected]>
Signed-off-by: Nguyen, Tom CITZ:EX <[email protected]>
Signed-off-by: Nguyen, Tom CITZ:EX <[email protected]>
Signed-off-by: Nguyen, Tom CITZ:EX <[email protected]>
bryce-mcmath
force-pushed
the
chore/prompt-biometrics-permission-onboarding
branch
from
2f9ef84 to
f4eb26c
Compare
|
tom11-nguyen
deleted the
chore/prompt-biometrics-permission-onboarding
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Related Issues
bcgov/bc-wallet-mobile#2111
#999
Pull Request Checklist
Tick all boxes below to demonstrate that you have completed the respective task. If the item does not apply to your this PR check it anyway to make it apparent that there's nothing to do.
Signed-off-byline (we use the DCO GitHub app to enforce this);If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!
Pro Tip 🤓
PR template adapted from the Python attrs project.