refactor: two state dispatches into one to prevent possible race (#1378)

Signed-off-by: Bryce McMath <[email protected]>

packages/legacy/core/App/contexts/reducers/store.ts

@@ -15,8 +15,7 @@ import { generateRandomWalletName } from '../../utils/helpers'
 import { PersistentStorage } from '../../services/storage'
 
 enum StateDispatchAction {
-  STATE_DISPATCH = 'state/stateDispatch',
-  STATE_LOADED = 'state/stateLoaded',
+  STATE_DISPATCH = 'state/stateDispatch'
 }
 
 enum OnboardingDispatchAction {
@@ -110,12 +109,9 @@ export interface ReducerAction<R> {
 
 export const reducer = <S extends State>(state: S, action: ReducerAction<DispatchAction>): S => {
   switch (action.type) {
-    case StateDispatchAction.STATE_LOADED: {
-      return { ...state, stateLoaded: true }
-    }
     case StateDispatchAction.STATE_DISPATCH: {
       const newState: State = (action?.payload || []).pop()
-      return { ...state, ...newState }
+      return { ...state, ...newState, stateLoaded: true }
     }
     case PreferencesDispatchAction.ENABLE_DEVELOPER_MODE: {
       const choice = (action?.payload ?? []).pop() ?? false

packages/legacy/core/App/navigators/RootStack.tsx

@@ -13,7 +13,6 @@ import { DeviceEventEmitter } from 'react-native'
 import IconButton, { ButtonLocation } from '../components/buttons/IconButton'
 import { EventTypes } from '../constants'
 import { TOKENS, useServices } from '../container-api'
-import { DispatchAction } from '../contexts/reducers/store'
 import { useStore } from '../contexts/store'
 import { useTheme } from '../contexts/theme'
 import { useDeepLinks } from '../hooks/deep-links'
@@ -67,9 +66,6 @@ const RootStack: React.FC = () => {
 
   useEffect(() => {
     loadState(dispatch)
-      .then(() => {
-        dispatch({ type: DispatchAction.STATE_LOADED })
-      })
       .catch((err: unknown) => {
         const error = new BifoldError(t('Error.Title1044'), t('Error.Message1044'), (err as Error).message, 1001)
         DeviceEventEmitter.emit(EventTypes.ERROR_ADDED, error)