introduce ACAPY_NO_BANNER--no-banner and replace print statements by logging in plugins #3203
Conversation
rngadam
force-pushed
the
rngadam/issue3202
branch
2 times, most recently
from
2dd65ce to
8b1e818
Compare
There was a problem hiding this comment.
See my comments here; #3202 (comment). I don't think suppressing deprecation notices is a good idea, it defeats their purpose.
Regarding the standard ACA-Py startup banner. I think this is a very important piece of diagnostic information that should not be suppressed. It provides you with a summary of the agent configuration and version that can help you identify issues right off the bat.
Outputting the banner is the default. ACAPY_NO_BANNER allows to suppress the banner output in situation where the information in diagnostic is already known to the user. |
…nt by logging statements Signed-off-by: Ricky Ng-Adam <[email protected]>
rngadam
force-pushed
the
rngadam/issue3202
branch
from
8b1e818 to
12da754
Compare
|
|
I've added this to the ACA-Pug meeting coming up this Tuesday, Sept. 3 at 8:00 Pacific / 17:00 Central Europe. @rngadam -- would you be able to make that? Details are here: https://wiki.hyperledger.org/display/ARIES/2024-09-03+Aries+Cloud+Agent+-+Python+Users+Group+Community+Meeting |
|
Closing this as won't do. Feel free to re-open it if this is still something you really think is needed. |
see issue #3202