-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Experimental][TorchFX] OpenVINOQuantizer #3203
[Experimental][TorchFX] OpenVINOQuantizer #3203
Conversation
nncf/experimental/quantization/quantizers/openvino_quantizer.py
Outdated
Show resolved
Hide resolved
nncf/experimental/quantization/quantizers/openvino_quantizer.py
Outdated
Show resolved
Hide resolved
nncf/experimental/quantization/quantizers/openvino_quantizer.py
Outdated
Show resolved
Hide resolved
nncf/experimental/quantization/quantizers/openvino_quantizer.py
Outdated
Show resolved
Hide resolved
nncf/experimental/quantization/quantizers/openvino_quantizer.py
Outdated
Show resolved
Hide resolved
nncf/experimental/quantization/quantizers/openvino_quantizer.py
Outdated
Show resolved
Hide resolved
nncf/experimental/quantization/quantizers/openvino_quantizer.py
Outdated
Show resolved
Hide resolved
nncf/experimental/quantization/quantizers/openvino_quantizer.py
Outdated
Show resolved
Hide resolved
nncf/experimental/quantization/quantizers/openvino_quantizer.py
Outdated
Show resolved
Hide resolved
nncf/experimental/quantization/quantizers/openvino_quantizer.py
Outdated
Show resolved
Hide resolved
daa79c1
to
9721fa8
Compare
nncf/experimental/quantization/quantizers/openvino_quantizer.py
Outdated
Show resolved
Hide resolved
nncf/experimental/quantization/quantizers/openvino_quantizer.py
Outdated
Show resolved
Hide resolved
b953569
to
0999c82
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Please, address the last comments.
nncf/experimental/quantization/quantizers/openvino_quantizer.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
nncf/experimental/quantization/quantizers/openvino_quantizer.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
### Changes * torch.ao `OpenVINOQuantizer` as well as `OpenVINOQuantizerAdapter` are introduced * `quantize_pt2e` function is updated to work with `OpenVINOQuantizer` ### Reason for changes * To enable OpenVINO quantization for torch.ao quantization pipelines (`torch.ao.quantization.prepare_pt2e`, `torch.ao.quantization.convert_pt2e`) and quantize_pt2e API function ### Related tickets openvinotoolkit#2766 ### Tests tests/torch/fx/test_quantizer.py is updated with use cases: - `OpenVINOQuantizer` + `quantize_pt2e` - `OpenVINOQuantizer` +`torch.ao.quantization.prepare_pt2e` -> `torch.ao.quantization.convert_pt2e`
Follow up of #3203 ### Changes * torch.ao `OpenVINOQuantizer` as well as `OpenVINOQuantizerAdapter` are introduced * `quantize_pt2e` function is updated to work with `OpenVINOQuantizer` ### Reason for changes * To enable OpenVINO quantization for torch.ao quantization pipelines (`torch.ao.quantization.prepare_pt2e`, `torch.ao.quantization.convert_pt2e`) and quantize_pt2e API function ### Related tickets #2766 ### Tests tests/torch/fx/test_quantizer.py is updated with use cases: - `OpenVINOQuantizer` + `quantize_pt2e` - `OpenVINOQuantizer` +`torch.ao.quantization.prepare_pt2e` -> `torch.ao.quantization.convert_pt2e`
Changes
OpenVINOQuantizer
as well asOpenVINOQuantizerAdapter
are introducedquantize_pt2e
function is updated to work withOpenVINOQuantizer
Reason for changes
torch.ao.quantization.prepare_pt2e
,torch.ao.quantization.convert_pt2e
) and quantize_pt2e API functionRelated tickets
#2766
Tests
tests/torch/fx/test_quantizer.py is updated with use cases:
OpenVINOQuantizer
+quantize_pt2e
OpenVINOQuantizer
+torch.ao.quantization.prepare_pt2e
->torch.ao.quantization.convert_pt2e