Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(user): Add recent search entry after routingQuery. #1340

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

binh-dam-ibigroup
Copy link
Collaborator

Description

With this PR, a recent search entry is added after planning a trip and can be accessed from the recents list when clearing one or both of the origin/destination.
(Currently, you have to reload the page for recent searches to appear.)

PR Checklist:

  • Does the code follow accessibility standards (WCAG 2.1 AA Compliant)?
  • Are all languages supported (Internationalization/Localization)?
  • Are appropriate Typescript types implemented?

Copy link
Contributor

@daniel-heppner-ibigroup daniel-heppner-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, appreciate the simple change

Copy link
Contributor

@josh-willis-arcadis josh-willis-arcadis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great fix!

@binh-dam-ibigroup binh-dam-ibigroup merged commit 1eec0f8 into dev Jan 22, 2025
9 checks passed
@binh-dam-ibigroup binh-dam-ibigroup deleted the add-recent-search-after-plan branch January 22, 2025 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants