Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auto-set sort direction on sort type change #1315

Merged
merged 5 commits into from
Dec 26, 2024

Conversation

miles-grant-ibigroup
Copy link
Collaborator

Sets ASC/DESC automatically on changing the sort type.

Do we want this behavior like this by default? Curious for opinions

Copy link
Contributor

@amy-corson-ibigroup amy-corson-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On a new search, when I set d/t to "depart" I'm consistently getting this blank dropdown
image

@miles-grant-ibigroup miles-grant-ibigroup added the BLOCKED Blocked (waiting on another PR to be merged) label Dec 13, 2024
@miles-grant-ibigroup
Copy link
Collaborator Author

Blocked by #1316

# Conflicts:
#	lib/components/form/call-taker/date-time-picker.tsx
@miles-grant-ibigroup
Copy link
Collaborator Author

All is fixed after latest merge!

@miles-grant-ibigroup miles-grant-ibigroup removed the BLOCKED Blocked (waiting on another PR to be merged) label Dec 19, 2024
Copy link
Contributor

@amy-corson-ibigroup amy-corson-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@miles-grant-ibigroup miles-grant-ibigroup merged commit e567ee7 into dev Dec 26, 2024
9 checks passed
@miles-grant-ibigroup miles-grant-ibigroup deleted the auto-sort-on-sort branch December 26, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants