Prevent debug UI action from showing up in forked OTP projects #6402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #6402 +/- ##
==========================================
Coverage 69.73% 69.73%
+ Complexity 18023 18021 -2
==========================================
Files 2057 2057
Lines 76978 76978
Branches 7845 7845
==========================================
Hits 53678 53678
Misses 20550 20550
Partials 2750 2750 ☔ View full report in Codecov by Sentry. |
leonardehrenfried
approved these changes
Jan 23, 2025
leonardehrenfried
changed the title
optionsome
reviewed
Jan 24, 2025
There was a problem hiding this comment.
The title is slightly misleading as this only prevents the workflow being run in a fork if the fork doesn't use the same branch naming convention as upstream. Unfortunately I don't think there is a way to define on which repositories the action should run on (apart from the repository owner check that we already do here but with that solution the workflow still starts but is then aborted).
| @@ -2,6 +2,8 @@ name: Debug client | |||
|
|
|||
| on: | |||
| push: | |||
| branches: | |||
| - dev-2.x | |||
| paths: | |||
| - 'client/**' | |||
| pull_request: | |||
There was a problem hiding this comment.
You could add the same branch restriction here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This action is run today in entur downstream fork when someone changes a file under
/client/**. The action is aborted, but it clutter up the list of run actions. I am not an expert on workflows, but I chaned it slightly so the trigger now filter on both path and branch for pushes. This also make the script a bit cleaner, since the branch filter does not need to be repeated in the run section.Issue
🟥 There is no issue for this.
Unit tests
🟥 This is CI config change, we do not have tests for this.
Documentation
🟥 I have not changed/added doc.
Changelog
🟥 Not relevant
Bumping the serialization version id
🟥 There is no changes to the OTP code.