Conditionally wait for previous polling task #6401
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #6401 +/- ##
=============================================
- Coverage 69.73% 69.72% -0.01%
+ Complexity 18023 18022 -1
=============================================
Files 2057 2057
Lines 76978 76985 +7
Branches 7845 7844 -1
=============================================
- Hits 53678 53677 -1
- Misses 20550 20555 +5
- Partials 2750 2753 +3 ☔ View full report in Codecov by Sentry. |
vpaturet
force-pushed
the
conditionnaly_wait_for_previous_polling_task
branch
from
cf8acfe to
49b8134
Compare
vpaturet
force-pushed
the
conditionnaly_wait_for_previous_polling_task
branch
from
49b8134 to
55aae1f
Compare
vpaturet
added
Improvement
Real-Time Update
leonardehrenfried
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is a follow-up PR for #6262 that improves the blocking wait logic: the polling thread is blocked only if the previous task takes longer than the polling interval.
In this case a log message indicates the additional waiting period.
The encapsulation of the task submission to the graph writer thread was missing in the SIRI-SX and SIRI-ET updater, this is fixed. As a result the callback
saveResultOnGraphcan be made private inPollingGraphUpdater.The logic covers also the case when an updater sends several update tasks during one polling cycle.
Issue
No
Unit tests
The tests added in #6262 do not apply anymore and are removed.
Unit-testing the correctness of the logic introduced in this PR is impractical (multi-threading), so unfortunately no unit test is added.
Manual testing with the SIRI-SX polling updater in a local environment shows that the code works as expected.
Documentation
No