Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build modules for NGINX 1.25.4 #577

Merged
merged 1 commit into from
Feb 15, 2024
Merged

Build modules for NGINX 1.25.4 #577

merged 1 commit into from
Feb 15, 2024

Conversation

lucacome
Copy link
Member

Adds build for 1.25.4

@lucacome lucacome self-assigned this Feb 15, 2024
@github-actions github-actions bot added the dependencies Pull requests that update a dependency file label Feb 15, 2024
@lucacome lucacome added enhancement and removed dependencies Pull requests that update a dependency file labels Feb 15, 2024
@lucacome lucacome requested a review from miry February 15, 2024 03:12
@miry miry merged commit 5f45cc8 into master Feb 15, 2024
28 checks passed
@miry miry deleted the deps/bump-nginx branch February 15, 2024 09:45
@miry
Copy link
Collaborator

miry commented Feb 15, 2024

It seems I merged too early, sorry for this.
May be I forgot the process.

https://github.com/opentracing-contrib/nginx-opentracing/actions/runs/7913946399/job/21602809593#step:9:445

Should ci/build_module_binaries.sh be updated as well?

@miry
Copy link
Collaborator

miry commented Feb 15, 2024

I see we want to build for platform: linux/s390x

but there is no image with this platform in https://hub.docker.com/layers/library/nginx/1.25.4/images/sha256-05aa73005987caaed48ea8213696b0df761ccd600d2c53fc0a1a97a180301d71?context=explore&tab=vulnerabilities

image

May be it is possible to use approach to distribute build for each platform and then ignore if it was failed for some, like it was provided in example?

@lucacome
Copy link
Member Author

I don't think we would want to release different architectures, we probably want to wait for docker hub to fix this if it happens in the future.
I was already thinking about changing the build in the PR so that it builds for all platforms all the time, I guess this is giving me the nudge I needed 😄

@miry
Copy link
Collaborator

miry commented Feb 15, 2024

Also make sense. It could parse branch name or PR to run all platforms.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants