Skip to content

Commit

Permalink
fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
lucacome committed Jun 28, 2024
1 parent 15de3c2 commit afc6223
Show file tree
Hide file tree
Showing 5 changed files with 14 additions and 7 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/system-testing.yml
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ jobs:
with:
pull: true
load: true
file: Dockerfile-test
file: test/Dockerfile-test
tags: nginx-opentracing-test/nginx
cache-from: type=gha,scope=system-nginx
cache-to: type=gha,scope=system-nginx,mode=max
Expand Down Expand Up @@ -76,7 +76,7 @@ jobs:
python3 nginx_opentracing_test.py
env:
PYTHONPATH: environment/grpc
LOG_DIR: test-log
LOG_DIR: ${{ github.workspace }}/test-log
working-directory: test

- name: Upload artifact
Expand Down
3 changes: 3 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -41,3 +41,6 @@ test-log/
.DS_Store

out
bin
lib
pyvenv.cfg
9 changes: 7 additions & 2 deletions Makefile
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
NGINX_VERSION=1.27.0

.PHONY: docker-image
docker-image:
docker build -f Dockerfile -t opentracing-contrib/nginx-opentracing --target final .
Expand All @@ -7,11 +9,14 @@ docker-image-alpine:
docker build -f Dockerfile -t opentracing-contrib/nginx-opentracing --target final --build-arg BUILD_OS=alpine .

docker-build-binaries:
docker buildx build --build-arg NGINX_VERSION=1.27.0 --platform linux/amd64 -f build/Dockerfile -t nginx-opentracing-binaries --target=export --output "type=local,dest=out" --progress=plain --no-cache --pull .
docker buildx build --build-arg NGINX_VERSION=$(NGINX_VERSION) --platform linux/amd64 -f build/Dockerfile -t nginx-opentracing-binaries --target=export --output "type=local,dest=out" --progress=plain --no-cache --pull .

.PHONY: test
test:
./ci/system_testing.sh
docker build -t nginx-opentracing-test/nginx -f test/Dockerfile-test . --build-arg NGINX_VERSION=$(NGINX_VERSION)
docker build -t nginx-opentracing-test/backend -f test/Dockerfile-backend ./test
docker build -t nginx-opentracing-test/grpc-backend -f test/environment/grpc/Dockerfile ./test/environment/grpc
cd test && LOG_DIR=$(CURDIR)/test/test-log PYTHONPATH=environment/grpc python3 nginx_opentracing_test.py

.PHONY: clean
clean:
Expand Down
2 changes: 1 addition & 1 deletion Dockerfile-test → test/Dockerfile-test
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
FROM ubuntu:24.04

ARG OPENTRACING_CPP_VERSION=v1.6.0
ARG NGINX_VERSION=1.27.0
ARG NGINX_VERSION

RUN set -x \
&& apt-get update \
Expand Down
3 changes: 1 addition & 2 deletions test/environment/docker-compose.yaml
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
version: '3'
services:

nginx:
Expand Down Expand Up @@ -44,7 +43,7 @@ services:
- "5001:5001"

php_fpm:
image: php:7-fpm
image: php:8-fpm
networks:
testnet:
aliases:
Expand Down

0 comments on commit afc6223

Please sign in to comment.