Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: double decoding of json #319

Merged
merged 1 commit into from
Jan 29, 2024
Merged

fix: double decoding of json #319

merged 1 commit into from
Jan 29, 2024

Conversation

manchuck
Copy link
Contributor

@manchuck manchuck commented Jan 22, 2024

What is this PR doing?

This is addressing cases where decoding of JSON responses where being done in the callback rather than after the request is made.

How should this be manually tested?

What are the relevant tickets?

@manchuck manchuck force-pushed the fix-double-json-parse branch from 42217d8 to 7c547f1 Compare January 22, 2024 20:58
Copy link

codecov bot commented Jan 22, 2024

Codecov Report

Attention: 39 lines in your changes are missing coverage. Please review.

Comparison is base (111be34) 63.5% compared to head (7c547f1) 81.5%.
Report is 6 commits behind head on main.

Additional details and impacted files
Files Coverage Δ
spec/opentok_spec.js 100.0% <100.0%> (ø)
lib/moderation.js 93.1% <88.8%> (-2.6%) ⬇️
lib/signaling.js 88.8% <90.9%> (ø)
lib/opentok.js 76.4% <28.5%> (-0.4%) ⬇️
lib/client.js 93.6% <90.6%> (+14.6%) ⬆️
lib/render.js 19.6% <12.5%> (-2.0%) ⬇️
lib/callbacks.js 74.6% <77.1%> (+1.6%) ⬆️
lib/archiving.js 75.4% <77.2%> (+66.8%) ⬆️

... and 1 file with indirect coverage changes

@manchuck manchuck requested a review from abdulajet January 29, 2024 17:12
Copy link

@abdulajet abdulajet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@manchuck manchuck merged commit ee9eb27 into main Jan 29, 2024
14 checks passed
@manchuck manchuck deleted the fix-double-json-parse branch January 29, 2024 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants