-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sdk): MIC-1436: User can decrypt TDF files created with FileWatcher2.0.8 and older. #1833
base: main
Are you sure you want to change the base?
Conversation
sdk/tdf.go
Outdated
@@ -863,6 +863,10 @@ func (r *Reader) doPayloadKeyUnwrap(ctx context.Context) error { //nolint:gocogn | |||
|
|||
unencryptedMetadata = metaData | |||
} | |||
|
|||
if r.manifest.EncryptionInformation.KeyAccessObjs[0].SplitID == "" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this is for treating sid
-less multi-kao files as 'or', you should instead remove the mixedSplits
processing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dmihalcik-virtru is that what you meant (remove the mixedSplits)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you can also get rid of the if mixedSplits && ...
block below and remove the variable entirely
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If removing it is causing a regression, you can add this back and I'll take a look after this gets merged in
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you can also get rid of the
if mixedSplits && ...
block below and remove the variable entirely
got it - i will do changes
This reverts commit 2471816.
…o MIC-1436-old-tdf-fw-decrypt
Proposed Changes
*We need decrypt old FW tdf files. Old FW tdf files do not support SID and assertions are represented as JSON object
Checklist
Testing Instructions