Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(sdk): remove hex encoding #213

Merged
merged 23 commits into from
Jan 17, 2025
Merged

fix(sdk): remove hex encoding #213

merged 23 commits into from
Jan 17, 2025

Conversation

mkleene
Copy link
Contributor

@mkleene mkleene commented Nov 22, 2024 •
edited by dmihalcik-virtru
Loading

  • add a tdfVersion attribute to the manifest
  • when loading older versions hex-encode hashes
  • Adds --version option to command line tool

@mkleene mkleene changed the title add a class that does all hex encoding fix(sdk): remove hex encoding Dec 3, 2024
@mkleene mkleene marked this pull request as ready for review December 3, 2024 18:46
@mkleene mkleene requested review from a team as code owners December 3, 2024 18:46
sujankota
sujankota previously approved these changes Jan 7, 2025
View reviewed changes
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@dmihalcik-virtru dmihalcik-virtru self-requested a review January 16, 2025 19:08
@dmihalcik-virtru dmihalcik-virtru merged commit e076d11 into main Jan 17, 2025
7 of 8 checks passed
@dmihalcik-virtru dmihalcik-virtru deleted the remove-hex branch January 17, 2025 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmihalcik-virtru dmihalcik-virtru dmihalcik-virtru approved these changes

@sujankota sujankota sujankota left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mkleene @sujankota @dmihalcik-virtru