Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: incorrect isStreamable serialized name #210

Merged
merged 2 commits into from
Nov 13, 2024
Merged

fix: incorrect isStreamable serialized name #210

merged 2 commits into from
Nov 13, 2024

Conversation

strantalis
Copy link
Member

The isStreamable was generating the wrong serialized name in the manifest causing json schema validation to fail.

Before IsStreamable
After isStreamable

@strantalis strantalis requested review from a team as code owners November 10, 2024 01:55
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@strantalis strantalis merged commit 32825b0 into main Nov 13, 2024
7 checks passed
@strantalis strantalis deleted the serialized-name-bug branch November 13, 2024 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elizabethhealy elizabethhealy elizabethhealy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@strantalis @elizabethhealy