fix: retore files by order #4325
Conversation
|
Warning There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure. 🔧 eslint
warning [email protected]: This version is no longer supported. Please see https://eslint.org/version-support for other options. 概述演练在 变更
可能相关的 PR
建议标签
建议审阅者
Finishing Touches
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
packages/editor/src/browser/workbench-editor.service.ts (2)
2317-2319: 顺序恢复文件状态的实现看起来不错！通过使用
for...of循环顺序处理 URI，而不是使用Promise.all并行处理，可以确保文件按照原始顺序恢复。这样可以避免由于并行加载导致的文件顺序混乱问题。不过建议添加错误处理:
for (const uri of state.uris) { - await this.doOpen(new URI(uri), { disableNavigate: true, backend: true, preview: false, deletedPolicy: 'skip' }); + try { + await this.doOpen(new URI(uri), { disableNavigate: true, backend: true, preview: false, deletedPolicy: 'skip' }); + } catch (err) { + this.logger.error(`Failed to restore editor state for ${uri}: ${err}`); + } }🧰 Tools
🪛 Biome (1.9.4)
[error] 2317-2318: Change to an optional chain.
Unsafe fix: Change to an optional chain.
(lint/complexity/useOptionalChain)
2317-2318: 考虑使用可选链操作符为了提高代码的健壮性，建议使用可选链操作符：
- this.previewURI = state.uris[state.previewIndex] ? new URI(state.uris[state.previewIndex]) : null; + this.previewURI = state.uris?.[state.previewIndex] ? new URI(state.uris[state.previewIndex]) : null;🧰 Tools
🪛 Biome (1.9.4)
[error] 2317-2318: Change to an optional chain.
Unsafe fix: Change to an optional chain.
(lint/complexity/useOptionalChain)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
packages/editor/src/browser/workbench-editor.service.ts(2 hunks)
🧰 Additional context used
🪛 Biome (1.9.4)
packages/editor/src/browser/workbench-editor.service.ts
[error] 2317-2318: Change to an optional chain.
Unsafe fix: Change to an optional chain.
(lint/complexity/useOptionalChain)
⏰ Context from checks skipped due to timeout of 90000ms (8)
- GitHub Check: unittest (ubuntu-latest, 18.x, jsdom)
- GitHub Check: unittest (ubuntu-latest, 18.x, node)
- GitHub Check: unittest (macos-latest, 18.x, jsdom)
- GitHub Check: build (ubuntu-latest, 20.x)
- GitHub Check: build (macos-latest, 20.x)
- GitHub Check: unittest (macos-latest, 18.x, node)
- GitHub Check: build-windows
- GitHub Check: ubuntu-latest, Node.js 20.x
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4325 +/- ##
==========================================
- Coverage 54.19% 54.18% -0.01%
==========================================
Files 1637 1637
Lines 99983 99982 -1
Branches 21711 21869 +158
==========================================
- Hits 54181 54175 -6
- Misses 38055 38059 +4
- Partials 7747 7748 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Types
Background or solution
Changelog
Summary by CodeRabbit