fix destination_sign relations not updated when splitting a way
#10646
+64
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tordans
reviewed
Jan 3, 2025
tordans
reviewed
Jan 3, 2025
test/spec/actions/split.js
Outdated
| @@ -1674,7 +1676,7 @@ describe('iD.actionSplit', function () { | |||
| iD.osmRelation({id: 'r', tags: {type: type}, members: [ | |||
| {id: '-', role: 'from', type: 'way'}, | |||
| {id: '~', role: 'to', type: 'way'}, | |||
| {id: 'd', role: 'via', type: 'node'} | |||
| {id: 'd', role: via, type: 'node'} | |||
There was a problem hiding this comment.
When reading the changes, I did not immediately get this. Maybe a different name like viaKey would make it more explicit? (Code editors will also help with proper tool tips and highlighting, though)
k-yle
force-pushed
the
kh/9188-split-dest-sign
branch
from
c1f26f2 to
a0a918d
Compare
good point, although I can't think of concise word that encompasses |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9188
destination_signcan use theintersectionrole instead ofvia.There are still valid cases
destination_signrelations won't be split properly, such as if there is nofromrole. But this helps with the most common cases