Do not add ignore_issue if there are no other dynamic fixes, tries to fix #10614 #10632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Screen.Recording.2024-12-28.at.3.59.51.PM.1.mp4Here is a demonstration video to show how it fixes the issue |
|
This does not really solve the issue. It would also break all other validation warnings that don't provide dynamic fixes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tries to fix #10614
I have tried to solve the problem of the mapper getting mislead into thinking there is nothing else to fix by showing "ignore this issue" while adding a tunnel
I have added an extra check which prevents inserting the
ignore_issuevalidationIssueFixif there are no otherdynamicFixesin the context