-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] TRT-1922: Use JobTier for filtering jobs #2255
base: master
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: stbenjam The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Start setting `JobTier` to excluded on jobs we don't know about in Sippy's config. This makes Sippy's config authoritative for both CR and Sippy -- it should allow the data to match between the two, and for jobs we don't explicitly opt-in to to stop showing up in Component Readiness.
4fa6952
to
e0b109d
Compare
@stbenjam: This pull request references TRT-1922 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@stbenjam: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Any thoughts on how we could get past the fact that the jobtier is set based on the sippy config generator code. Would we pull that code in here and let it run once a day when the variant registry gets updated? |
Start setting
JobTier
to excluded on jobs we don't know about in Sippy's config. This makes Sippy's config authoritative for both CR and Sippy -- it should allow the data to match between the two, and for jobs we don't explicitly opt-in to to stop showing up in Component Readiness.