Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] TRT-1922: Use JobTier for filtering jobs #2255

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

stbenjam
Copy link
Member

Start setting JobTier to excluded on jobs we don't know about in Sippy's config. This makes Sippy's config authoritative for both CR and Sippy -- it should allow the data to match between the two, and for jobs we don't explicitly opt-in to to stop showing up in Component Readiness.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 14, 2025
@openshift-ci openshift-ci bot requested review from dgoodwin and sosiouxme January 14, 2025 19:41
Copy link
Contributor

openshift-ci bot commented Jan 14, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: stbenjam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 14, 2025
Start setting `JobTier` to excluded on jobs we don't know about in
Sippy's config. This makes Sippy's config authoritative for both CR and
Sippy -- it should allow the data to match between the two, and for jobs
we don't explicitly opt-in to to stop showing up in Component Readiness.
@stbenjam stbenjam changed the title [WIP] Use JobTier for filtering jobs [WIP] TRT-1922: Use JobTier for filtering jobs Jan 14, 2025
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 14, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 14, 2025

@stbenjam: This pull request references TRT-1922 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

Start setting JobTier to excluded on jobs we don't know about in Sippy's config. This makes Sippy's config authoritative for both CR and Sippy -- it should allow the data to match between the two, and for jobs we don't explicitly opt-in to to stop showing up in Component Readiness.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Contributor

openshift-ci bot commented Jan 14, 2025

@stbenjam: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/build e0b109d link true /test build
ci/prow/e2e e0b109d link true /test e2e
ci/prow/lint e0b109d link true /test lint
ci/prow/unit e0b109d link true /test unit
ci/prow/images e0b109d link true /test images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@dgoodwin
Copy link
Contributor

Any thoughts on how we could get past the fact that the jobtier is set based on the sippy config generator code. Would we pull that code in here and let it run once a day when the variant registry gets updated?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants