Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS#42701: Updated the disableMultiNetwork parameter in Network A… #86936

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

OCPBUGS#42701: Updated the disableMultiNetwork parameter in Network A… #86936

wants to merge 1 commit into from

Conversation

dfitzmau
Copy link
Contributor

@dfitzmau dfitzmau commented Jan 13, 2025 •
edited
Loading

PEER REVIEWER: THIS IS AN UNUSUAL UPDATE FOR THE DOCS TEAM AS THE UPDATE HAPPENS IN AN ENGINEERING REPO BUT FOR REVIEW PURPOSES I CREATED THIS PR. IDEALLY REVIEW THE CONTENT ON openshift/api#2143

Version(s):
4.12+

Issue:
OCPBUGS-42701

Link to docs preview:
disableMultiNetwork

  • SME has approved this change (Doug Smith).
  • QE has approved this change (Weibin Liang).

Resources:

@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jan 13, 2025
@openshift-ci-robot
Copy link

@dfitzmau: This pull request references Jira Issue OCPBUGS-42701, which is invalid:

  • expected the bug to target the "4.19.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

…PI doc

Version(s):

Issue:

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 13, 2025
@dfitzmau dfitzmau changed the title OCPBUGS-42701: Updated the disableMultiNetwork parameter in Network A… OCPBUGS#42701: Updated the disableMultiNetwork parameter in Network A… Jan 13, 2025
@openshift-ci-robot openshift-ci-robot removed jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jan 13, 2025
@openshift-ci-robot
Copy link

@dfitzmau: No Jira issue is referenced in the title of this pull request.
To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh.

In response to this:

Version(s):
4.12+

Issue:
OCPBUGS-37491

Link to docs preview:

  • SME has approved this change.
  • QE has approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Jan 13, 2025 •
edited
Loading

🤖 Wed Jan 15 17:09:55 - Prow CI generated the docs preview:

https://86936--ocpdocs-pr.netlify.app/openshift-enterprise/latest/rest_api/operator_apis/network-operator-openshift-io-v1.html

@dfitzmau dfitzmau force-pushed the OCPBUGS-42701 branch 2 times, most recently from ae1507f to 9986c5d Compare January 13, 2025 10:24
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jan 15, 2025

@dfitzmau: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@dfitzmau dfitzmau added the peer-review-needed Signifies that the peer review team needs to review this PR label Jan 16, 2025
@xenolinux xenolinux added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Jan 16, 2025
xenolinux
xenolinux reviewed Jan 16, 2025
View reviewed changes
Copy link
Contributor

@xenolinux xenolinux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Considering we do not modify API descriptions -- LGTM

@xenolinux xenolinux added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Jan 16, 2025
pliurh
pliurh reviewed Jan 20, 2025
View reviewed changes
rest_api/operator_apis/network-operator-openshift-io-v1.adoc
| disableMultiNetwork specifies whether or not multiple pod network
support should be disabled. If unset, this property defaults to
'false' and multiple network support is enabled.
| "disableMultiNetwork defaults to 'false' and this setting enables the pod multi-networking capability. disableMultiNetwork when set to 'true' at cluster install time does not install the components, typically the Multus CNI and the network-attachment-definition CRD, that enable the pod multi-networking capability. Setting the parameter to 'true' might be useful when you need install third-party CNI plugins, but these plugins are not supported by Red Hat. Changing the parameter value as a postinstallation cluster task has no effect.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing the parameter value as a postinstallation cluster task has no effect.

I prefer is not allowed.

@pliurh
Copy link
Contributor

pliurh commented Jan 20, 2025

@dougbtv PTAL

@dougbtv
Copy link
Member

dougbtv commented Jan 24, 2025

I'm good with "is not allowed", too. It is certainly more direct. "Has no effect" is also true, but, Peng has a point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xenolinux xenolinux xenolinux left review comments

@pliurh pliurh pliurh left review comments

Assignees
No one assigned
Labels
branch/enterprise-4.12 branch/enterprise-4.13 branch/enterprise-4.14 branch/enterprise-4.15 branch/enterprise-4.16 branch/enterprise-4.17 branch/enterprise-4.18 peer-review-done Signifies that the peer review team has reviewed this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@dfitzmau @openshift-ci-robot @ocpdocs-previewbot @pliurh @dougbtv @xenolinux