Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporary removes arm64 references in the OKD doc flavour #46780

Merged
merged 1 commit into from
Jun 21, 2022

Conversation

aleskandro
Copy link
Member

This PR wants to temporarily remove the arm64 refs in the OKD doc until ARM64 OKD builds will be available.

Version(s): 4.10+

This refers okd-project/okd#1165

/cc @LorbusChris @mburke5678 @kelbrown20

Link to docs preview:

Additional information:

@openshift-ci openshift-ci bot requested review from mburke5678 and LorbusChris June 16, 2022 14:01
@openshift-ci
Copy link

openshift-ci bot commented Jun 16, 2022

@aleskandro: GitHub didn't allow me to request PR reviews from the following users: kelbrown20.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

This PR wants to temporarily remove the arm64 refs in the OKD doc until ARM64 OKD builds will be available.

Version(s): 4.10+

This refers okd-project/okd#1165

/cc @LorbusChris @mburke5678 @kelbrown20

Link to docs preview:

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 16, 2022
@mburke5678
Copy link
Contributor

@kelbrown20 PTAL

Copy link
Contributor

@kelbrown20 kelbrown20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aleskandro Hi Alessandro! These comments are mainly just updates to follow our writing guidelines. Other than that, this looks great! Once this is updated, I can create the doc previews to verify the changes, then I'll add them to the comments here. Thank you for filing this PR!

installing/installing-preparing.adoc Outdated Show resolved Hide resolved
modules/architecture-rhcos-updating-bootloader.adoc Outdated Show resolved Hide resolved
modules/installation-configuration-parameters.adoc Outdated Show resolved Hide resolved
modules/installation-aws-ami-stream-metadata.adoc Outdated Show resolved Hide resolved
modules/installation-configuration-parameters.adoc Outdated Show resolved Hide resolved
modules/installation-user-infra-machines-pxe.adoc Outdated Show resolved Hide resolved
modules/installation-user-infra-machines-pxe.adoc Outdated Show resolved Hide resolved
@mburke5678
Copy link
Contributor

Previews:
Do you want to install and manage an OpenShift Container Platform cluster yourself?. No ARM in platform list
Updating the bootloader using bootupd No arm example after step 1
Accessing FCOS AMIs with stream metadata. Remove arm64 from bullet 3's sub-bullet
Installation configuration parameters. TBD after ifdef fixes
Supported AWS machine types. No Machine types based on arm64 architecture list
Installing FCOS by using PXE or iPXE booting
. No arm64 in second bullet in step 6; no To network boot the CoreOS kernel on arm64 architecture note

@aleskandro
Copy link
Member Author

@aleskandro Hi Alessandro! These comments are mainly just updates to follow our writing guidelines. Other than that, this looks great! Once this is updated, I can create the doc previews to verify the changes, then I'll add them to the comments here. Thank you for filing this PR!

Thanks @kelbrown20. They should have been addressed in the last commit.

@kelbrown20
Copy link
Contributor

kelbrown20 commented Jun 16, 2022

Looks great, LGTM
@mburke5678 Thank you for those previews, can you also please take a look the updates?

@mburke5678 mburke5678 merged commit 5e0710c into openshift:main Jun 21, 2022
@mburke5678
Copy link
Contributor

/cherrypick enterprise-4.10

@openshift-cherrypick-robot

@mburke5678: new pull request created: #46902

In response to this:

/cherrypick enterprise-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mburke5678
Copy link
Contributor

/cherrypick enterprise-4.11

@openshift-cherrypick-robot

@mburke5678: new pull request created: #46903

In response to this:

/cherrypick enterprise-4.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch/enterprise-4.10 branch/enterprise-4.11 size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants