Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MON-4129: adjust Prometheus classic histograms 'le' related selectors in relabel config to accommodate the update to Prometheus v3 #752

Merged
merged 1 commit into from
Feb 4, 2025

Conversation

machine424
Copy link
Contributor

No description provided.

@openshift-ci openshift-ci bot requested review from ibihim and liouk January 16, 2025 10:29
@machine424 machine424 changed the title adjust histograms 'le' related selectors WIP: adjust histograms 'le' related selectors Jan 16, 2025
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 16, 2025
Copy link
Contributor

openshift-ci bot commented Jan 16, 2025

@machine424: This PR was included in a payload test run from openshift/cluster-monitoring-operator#2554
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-nightly-4.19-e2e-rosa-sts-hypershift-ovn

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/50647e70-d3fb-11ef-84ae-020c1e634813-0

Copy link
Contributor

openshift-ci bot commented Jan 16, 2025

@machine424: This PR was included in a payload test run from openshift/cluster-monitoring-operator#2554
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-nightly-4.19-e2e-rosa-sts-ovn

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/6c58b6a0-d3fb-11ef-9ad3-ed24ac0f8204-0

Copy link
Contributor

openshift-ci bot commented Jan 16, 2025

@machine424: This PR was included in a payload test run from openshift/cluster-monitoring-operator#2554
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-nightly-4.19-e2e-rosa-sts-ovn

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/88b2b380-d411-11ef-93dc-3c642b2d31ff-0

@machine424
Copy link
Contributor Author

machine424 commented Jan 17, 2025

/retitle MON-4129: adjust Prometheus histograms 'le' related selectors in relabel config

@openshift-ci openshift-ci bot changed the title WIP: adjust histograms 'le' related selectors MON-4129: adjust Prometheus histograms 'le' related selectors in relabel config Jan 17, 2025
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 17, 2025
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 17, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 17, 2025

@machine424: This pull request references MON-4129 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.19.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@machine424 machine424 changed the title MON-4129: adjust Prometheus histograms 'le' related selectors in relabel config WIP: MON-4129: adjust Prometheus histograms 'le' related selectors in relabel config Jan 17, 2025
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 17, 2025
@machine424
Copy link
Contributor Author

/retest

@machine424
Copy link
Contributor Author

machine424 commented Jan 30, 2025

/retitle MON-4129: adjust Prometheus classic histograms 'le' related selectors in relabel config to accommodate the update to Prometheus v3

@openshift-ci openshift-ci bot changed the title WIP: MON-4129: adjust Prometheus histograms 'le' related selectors in relabel config MON-4129: adjust Prometheus classic histograms 'le' related selectors in relabel config to accommodate the update to Prometheus v3 Jan 30, 2025
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 30, 2025
@machine424
Copy link
Contributor Author

/retest-required

@machine424
Copy link
Contributor Author

/label acknowledge-critical-fixes-only

@openshift-ci openshift-ci bot added the acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. label Jan 31, 2025
@ibihim
Copy link
Contributor

ibihim commented Feb 3, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 3, 2025
@deads2k
Copy link
Contributor

deads2k commented Feb 3, 2025

interesting that the integration test doesn't apply thing

/approve

Copy link
Contributor

openshift-ci bot commented Feb 3, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, ibihim, machine424

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 3, 2025
@machine424
Copy link
Contributor Author

interesting that the integration test doesn't apply thing

Took a look (even though the job isn't required) and I assumed that's a known issue and would be addressed in a following PR: #750 (comment)

Copy link
Contributor

openshift-ci bot commented Feb 3, 2025

@machine424: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/test-operator-integration 69c8692 link false /test test-operator-integration

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD be6819e and 2 for PR HEAD 69c8692 in total

@openshift-merge-bot openshift-merge-bot bot merged commit efbdcff into openshift:master Feb 4, 2025
12 of 13 checks passed
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: ose-cluster-authentication-operator
This PR has been included in build ose-cluster-authentication-operator-container-v4.19.0-202502040406.p0.gefbdcff.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants