-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MGMT-19258: Split KubeAPI and non KubeAPI subsystem tests #7154
Conversation
Skipping CI for Draft Pull Request. |
@paul-maidment: This pull request references MGMT-19258 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@paul-maidment: This pull request references MGMT-19258 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@paul-maidment: This pull request references MGMT-19258 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@paul-maidment: This pull request references MGMT-19258 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@paul-maidment: This pull request references MGMT-19258 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@paul-maidment: This pull request references MGMT-19258 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@paul-maidment: This pull request references MGMT-19258 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7154 +/- ##
==========================================
+ Coverage 67.60% 68.06% +0.45%
==========================================
Files 296 296
Lines 40266 40619 +353
==========================================
+ Hits 27223 27646 +423
+ Misses 10590 10512 -78
- Partials 2453 2461 +8 |
49cde10
to
01a8a88
Compare
8930f91
to
1dce038
Compare
0ce3c54
to
2dddd54
Compare
2dddd54
to
4960681
Compare
@paul-maidment: This pull request references MGMT-19258 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
1 similar comment
@paul-maidment: This pull request references MGMT-19258 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
We are dealing with an issue where some tests have not been executed since they were created, this is because they lack the [kube-api] tag in the test name. It's not ideal. I have decided to solve this by placing the KubeAPI and non KubeAPI tests into different packages github.com/openshift/assisted-service/subsystem for non KubeAPI tests github.com/openshift/assisted-service/subsystem/kubeapi for KubeAPI tests Now every test within the respective package will be executed, irrespective of how it has been tagged. In order to get to this point, some refactoring of common code between tests was required. The common code has been placed in a package called utils_test. Each of the test suites has been manually executed and confirmed to be working after these changes. KubeAPI tests now run without the need for a [kube-api] label. Some kube-api tests that never executed before this fix were found to be failing after they started to run. These tests have been disabled by marking them with PDescribe for now as they have been broken for some time and are non-trivial to fix. These tests will be dealt with in MGMT-19596
4960681
to
eba0446
Compare
/test edge-e2e-ai-operator-disconnected-capi |
/retest-required |
|
||
test-kube-api: | ||
$(MAKE) _run_subsystem_test AUTH_TYPE=local FOCUS="$(or ${FOCUS},kube-api)" | ||
$(MAKE) _run_subsystem_test AUTH_TYPE=local TEST="$(or $(TEST),'github.com/openshift/assisted-service/subsystem/kubeapi')" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No way this is running some code that is not local right ? e.g remote github.com/openshift/assisted-service
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's literally the name of the package
You can see here in go list...
paulmaidment@fedora ~/projects/workspaces/1/assisted-service/subsystem (MGMT-19258)$ go list ./...
github.com/openshift/assisted-service/subsystem
github.com/openshift/assisted-service/subsystem/kubeapi
github.com/openshift/assisted-service/subsystem/utils_test
It's the pattern that the package name is fully qualified with the module URI from go mod
module github.com/openshift/assisted-service
Always easy to verify in any case, just change one test and watch it fail. Which I have already seen.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice !
/override ci/prow/edge-e2e-ai-operator-disconnected-capi |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danmanor, paul-maidment The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@danmanor: Overrode contexts on behalf of danmanor: ci/prow/edge-e2e-ai-operator-disconnected-capi In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@paul-maidment: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
[ART PR BUILD NOTIFIER] Distgit: ose-agent-installer-api-server |
We are dealing with an issue where some tests have not been executed since they were created, this is because they lack the [kube-api] tag in the test name. It's not ideal.
I have decided to solve this by placing the KubeAPI and non KubeAPI tests into different packages
github.com/openshift/assisted-service/subsystem for non KubeAPI tests
github.com/openshift/assisted-service/subsystem/kubeapi for KubeAPI tests
Now every test within the respective package will be executed, irrespective of how it has been tagged.
In order to get to this point, some refactoring of common code between tests was required. The common code has been placed in a package called utils_test.
Each of the test suites has been manually executed and confirmed to be working after these changes. KubeAPI tests now run without the need for a [kube-api] label.
Some kube-api tests that never executed before this fix were found to be failing after they started to run.
These tests have been disabled by marking them with PDescribe for now as they have been broken for some time and are non-trivial to fix.
These tests will be dealt with in MGMT-19596
List all the issues related to this PR
What environments does this code impact?
How was this code tested?
Checklist
docs
, README, etc)Reviewers Checklist