Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OAPE-94: Update API doc for route externalCertificate #2159

Merged
merged 1 commit into from
Jan 29, 2025
Merged

OAPE-94: Update API doc for route externalCertificate #2159

merged 1 commit into from
Jan 29, 2025

Conversation

chiragkyal
Copy link
Member

Update API godoc to document that manual intervention is required for using .spec.tls.externalCertificate.

https://issues.redhat.com/browse/OAPE-94

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 21, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 21, 2025 •
edited by openshift-ci bot
Loading

@chiragkyal: This pull request references OAPE-94 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

Update API godoc to document that manual intervention is required for using .spec.tls.externalCertificate.

https://issues.redhat.com/browse/OAPE-94

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 21, 2025

Hello @chiragkyal! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 21, 2025
@openshift-ci openshift-ci bot requested review from JoelSpeed and knobunc January 21, 2025 06:35
@chiragkyal
Copy link
Member Author

/cc @Miciah @alebedev87

@openshift-ci openshift-ci bot requested review from alebedev87 and Miciah January 21, 2025 06:36
@chiragkyal
Copy link
Member Author

/assign @JoelSpeed

@JoelSpeed
Copy link
Contributor

Will let more local SMEs review the text update, ping me when you need an approve label

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 28, 2025

@chiragkyal: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@alebedev87
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 29, 2025
@chiragkyal
Copy link
Member Author

@JoelSpeed, up for your review/approval

@JoelSpeed
Copy link
Contributor

/lgtm

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 29, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alebedev87, chiragkyal, JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 29, 2025
@chiragkyal
Copy link
Member Author

Since this is only a docs update, should we add acknowledge-critical-fixes-only label as well?

@JoelSpeed
Copy link
Contributor

/label acknowledge-critical-fixes-only

Docs only

@openshift-ci openshift-ci bot added the acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. label Jan 29, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 107848b into openshift:master Jan 29, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

@knobunc knobunc Awaiting requested review from knobunc

@alebedev87 alebedev87 Awaiting requested review from alebedev87

@Miciah Miciah Awaiting requested review from Miciah

Assignees

@JoelSpeed JoelSpeed

@alebedev87 alebedev87

Labels
acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chiragkyal @openshift-ci-robot @JoelSpeed @alebedev87