Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api: manifests: add scorecard annotations #154

Merged
merged 2 commits into from
Feb 16, 2022

Conversation

ffromani
Copy link
Member

add annotations to make the operator-sdk scorecard check happy.

add annotations to make the operator-sdk scorecard check happy.

Signed-off-by: Francesco Romani <[email protected]>
automatic regenerate manifests using `make generate manifests bundle

Signed-off-by: Francesco Romani <[email protected]>
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 16, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fromanirh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 16, 2022
@cynepco3hahue
Copy link
Contributor

/lgtm
Can we add a scorecard check under the CI to avoid such issue in the future, for sure it is subject for a separate PR.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 16, 2022
@ffromani
Copy link
Member Author

/lgtm Can we add a scorecard check under the CI to avoid such issue in the future, for sure it is subject for a separate PR.

that's a very nice idea: #155

@ffromani
Copy link
Member Author

well known flake, for which we don't have a good solution yet

@ffromani
Copy link
Member Author

/cherry-pick release-4.10

@openshift-cherrypick-robot

@fromanirh: once the present PR merges, I will cherry-pick it on top of release-4.10 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@fromanirh: new pull request created: #156

In response to this:

/cherry-pick release-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ffromani ffromani deleted the scorecard-annotations branch February 16, 2022 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants