Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api: helper: fix NodeGroup Name #1185

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

api: helper: fix NodeGroup Name #1185

wants to merge 1 commit into from

Conversation

ffromani
Copy link
Member

@ffromani ffromani commented Feb 5, 2025

Problems with the current NodeGroup. ToString() method:

  1. string representation of annotations, being them maps, is not stable, and we had no test coverage
  2. the string representation can be very long, and in some places (e.g. conditions) we need a much more concise representation.

Fix both issues:

  1. make representation of annotations stable
  2. shorten a tiny bit ToString() but most notably add a concise GetName() method; use it on validation.

Problems with the current `NodeGroup`. ToString() method:
1. string representation of annotations, being them maps, is not stable,
   and we had no test coverage
2. the string representation can be very long, and in some places (e.g.
   conditions) we need a much more concise representation.

Fix both issues:
1. make representation of annotations stable
2. shorten a tiny bit `ToString()` but most notably add a concise
   `GetName()` method; use it on validation.

Signed-off-by: Francesco Romani <[email protected]>
Copy link
Contributor

openshift-ci bot commented Feb 5, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ffromani

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 5, 2025
@ffromani
Copy link
Member Author

ffromani commented Feb 5, 2025

/retest-required

@ffromani
Copy link
Member Author

ffromani commented Feb 5, 2025

/test ci-e2e-install-hypershift

Copy link
Contributor

openshift-ci bot commented Feb 5, 2025

@ffromani: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/ci-e2e-install-hypershift fbe6148 link true /test ci-e2e-install-hypershift

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@ffromani
Copy link
Member Author

ffromani commented Feb 5, 2025

 INFO[2025-02-05T21:43:12Z] Build src-bundle failed, printing logs:      
INFO[2025-02-05T21:43:14Z] Build src-bundle previously failed from an infrastructure error (FetchImageContentFailed), retrying... 
INFO[2025-02-05T21:43:14Z] Ran for 16m44s                               
ERRO[2025-02-05T21:43:14Z] Some steps failed:         

let's wait

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant